Fix/people search service profile picture image url #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 31, 2020 14:58
…resolved by user's accountName
…resolved by user's accountName
…resolved by user's accountName
…resolved by user's accountName
|
Thank you @juhaalhojoki! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Noticed that an image for a user picked in PeoplePicker didn't get resolved on my dev tenant for my test users even when they have profile picture set.
PeopleSearchService:
Issue: The generateUserPhotoLink(value: string) method that resolves user's profile picture URL takes user's email address as an input parameter as the parameter for the accountName query string parameter. If users don't have email address set or email address does not match user's account name, image cannot be resolved.
Fix: using Description field from the response solves the issue. Description field contains user's account name.