Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: added additional props for File Picker #668

Merged
merged 3 commits into from
Sep 18, 2020

Conversation

gautamdsheth
Copy link
Contributor

@gautamdsheth gautamdsheth commented Sep 16, 2020

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? NA

What's in this Pull Request?

Added 2 additional properties to the file picker control.

  1. isPanelOpen - this will directly open the file picker panel
  2. onCancel - this will provide a callback when the file picker is cancelled. This was mentioned in How to detect when the file picker is canceled? #665

Can you also add this to the v1 branch as well ? Let me know if I need to open a separate PR for the same.

@estruyf estruyf merged commit be69314 into pnp:dev Sep 18, 2020
@estruyf
Copy link
Member

estruyf commented Sep 18, 2020

Thank you @gautamdsheth!

@AJIXuMuK AJIXuMuK added this to the 2.0.0 milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants