Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature > ListView > StickyHeader > Code consistency #697

Merged
merged 3 commits into from Oct 17, 2020

Conversation

aaclage
Copy link
Contributor

@aaclage aaclage commented Oct 14, 2020

Q A
Bug fix? [X]
New feature? [ ]
New sample? [ ]
Related issues? fixes #696

What's in this Pull Request?

For code consistency the following actions were made.
Removal of bad practices (css files and function with embedded string) to scss and associated string.
This PR remove embedded string "StickyHeader" and associated function to be replaced by scss and React validation.

This PR also fix multiple columns View, old style was limiting width of columns Views when horizontal scroll appear.
Test with additional Multiple Columns "Horizontal scroll":
image

Test with Multiple Columns that fit width:
image

@AJIXuMuK AJIXuMuK merged commit 7b0ab4a into pnp:dev Oct 17, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @aaclage for the update!

@AJIXuMuK AJIXuMuK added this to the 2.1.0 milestone Oct 17, 2020
@estruyf estruyf mentioned this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants