Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image support (RichText) #705

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Add image support (RichText) #705

merged 1 commit into from
Oct 28, 2020

Conversation

Abderahman88
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? mentioned in #701

What's in this Pull Request?

Insert images in RichText-control

  • Added button 'Image' to the toolbar (next to link-button)
  • Import image using URL path (if path is not valid, dialog will automatically close)

Remarques

  • Only images hosted on SharePoint are currently supported.

addImage

embeddedImage

@aaclage
Copy link
Contributor

aaclage commented Oct 22, 2020 •
edited
Loading

@Abderahman88 Doesn't allow binary image copy paste, correct?

@Abderahman88
Copy link
Contributor Author

@aaclage Correct. It is still pretty basic. Only hyperlinks of SP images can be added.
(Not supported: external images, drag/drop, copy/paste, ...)

@AJIXuMuK AJIXuMuK merged commit be4b905 into pnp:dev Oct 28, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @Abderahman88 for the enhancement!

@AJIXuMuK AJIXuMuK added this to the 2.2.0 milestone Oct 28, 2020
@estruyf estruyf mentioned this pull request Dec 3, 2020
Merged
@michaelmaillot michaelmaillot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Abderahman88 @aaclage @AJIXuMuK