Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated stuff #733

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Remove deprecated stuff #733

merged 3 commits into from
Nov 17, 2020

Conversation

gautamdsheth
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [x]
New sample? [ ]
Related issues? NA

What's in this Pull Request?

This PR

  1. Removes some unused imports.
  2. Since the upgrade to SPFx 1.11 and minor fabric upgrade, there were some deprecated imports we were using , so fixed them. They are mostly related to Spinner and Icon components. Also, removed the IWebpartContext and used the WebpartContext

@AJIXuMuK AJIXuMuK merged commit 3572a42 into pnp:dev Nov 17, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @gautamdsheth for the changes!

@AJIXuMuK AJIXuMuK added this to the 2.2.0 milestone Nov 17, 2020
@estruyf estruyf mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gautamdsheth @AJIXuMuK @estruyf