Fix case sensitive fluent icon search service

[mbice]

Q	A
Bug fix?	[X]
New feature?	[ ]
New sample?	[ ]
Related issues?	Nothing logged I could find

What's in this Pull Request?

There is an issue in the Icon Picker control where searching for Fluent icon names is case sensitive. For example, searching for "aadlogo" will return an icon, whereas searching for "AADLogo", which is the friendly name of the icon, returns nothing.

Searching for "aadlogo"

Searching for "AADLogo"

This fix ensures that the casing of the search term is ignored so that icons are returned regardless of lower/uppercase characters.

Thanks!

[AJIXuMuK]

Thank you @mbice for the fix!

I've merged it with a small change: I reverted back !startsWith to startsWith === false because this change reverses the default behavior.

[mbice]

Thanks for the merge, @AJIXuMuK.

Sorry, I should have documented the change to "startsWith" as well. I noticed that this method is not always being called with the startsWith parameter, as it's optional. In the case of the iconPicker, nothing gets passed in, so startsWith === false will never evaluate as true. In the case of the icon picker this means it will always string match from the starting of the string. I changed it to !startsWith so that either explicitly passed in as "false" or not provided would be true.

Thoughts?

Here's the call from icon picker:

[AJIXuMuK]

Got it @mbice!

I added it back and also added a new prop to the controls to be able to switch the behavior.