Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard widget wrapper for styling and error catching #836

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

Konradox
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Added new property for Dashboard component. One can now provide a component to wrap every Widget component inside Dashboard. The wrapper can handle errors or provide a new set of styles.

By default, when Widget fails, the whole Dashboard crashes. That was the reason for this change.

@AJIXuMuK
Copy link
Collaborator

Thank you @Konradox for the enhancement!

@AJIXuMuK AJIXuMuK merged commit 1fc6151 into pnp:dev Mar 19, 2021
@AJIXuMuK AJIXuMuK added this to the 2.6.0 milestone Mar 19, 2021
@estruyf estruyf mentioned this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants