Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Improved Finnish translations #937

Merged
merged 2 commits into from Jun 22, 2021
Merged

Conversation

gautamdsheth
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [x]
New sample? [ ]
Related issues? NA

What's in this Pull Request?

Improved Finnish translations.
We checked with our team and found that these machine generated translations were somewhat misleading in Finnish so improved them

Added stock images missing keys for Finnish locale.
Looks like the stock images localization keys are missing for all languages except English, can you guys check that ?
Have added the correct one for Finnish.
Also, added Org Assets additional key for localization.

@joelfmrodrigues joelfmrodrigues merged commit 792a129 into pnp:dev Jun 22, 2021
@joelfmrodrigues
Copy link
Collaborator

@gautamdsheth many thanks! PS: I obviously don't know Finnish 😂

@gautamdsheth
Copy link
Contributor Author

Same here as well ! Our colleagues were kind enough to help me :)
Btw any chance you can take a look at the stock images keys issue ?
It is missing from non-English locales.

@estruyf estruyf mentioned this pull request Jun 23, 2021
@joelfmrodrigues
Copy link
Collaborator

@gautamdsheth sorry, had this on my inbox with a million other emails and only reading it now. Can you send/tag me on the issue you are referring to, if still open?
I have had very limited time over the last few weeks, but can have a look when I get the chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants