Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues and update news ticker SPFX version #502

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

AriGunawan
Copy link
Contributor

@AriGunawan AriGunawan commented Aug 27, 2022

Q A
Bug fix? yes
New feature? yes
Related issues? #486 , #479

What's in this Pull Request?

  • Fixed failed load app because the last update (upgrade SPFx version to 1.14) seems not correctly implemented (missed react, react-dom, types, modules, changed ids, etc)
  • Upgrade SPFx version to 1.15.2
  • Upgrade PnPJS version to 3

@AriGunawan AriGunawan changed the title Features/update news ticker version Fix issues and update news ticker SPFX version Oct 16, 2022
@PaoloPia PaoloPia merged commit e29e8d7 into pnp:main Nov 11, 2022
@PaoloPia
Copy link
Collaborator

Hi @AriGunawan,
Thanks for your contribution.
Any chance you'd be interested in doing a live 10-15 min demo on this in our upcoming community calls? A good demo structure would be to have a few slides explaining the scenario and why it matters, then do a live demo and then move to code to show the key parts.

Would you be interested in this? Let us know. Thx

@PaoloPia
Copy link
Collaborator

If you are interested, please submit your demo through this form: https://aka.ms/m365pnp/request/demo . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants