Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm fatally errors when a package contains a whitespace-only license field. #1067

Closed
Tellan opened this issue Mar 6, 2018 · 3 comments
Closed

Comments

@Tellan
Copy link

Tellan commented Mar 6, 2018

pnpm version: 1.35.3

Code to reproduce the issue:

https://gist.github.com/Tellan/e76e9f58acc7afb71fe67368772de1d8

Expected behavior:

pnpm install should successfully complete.

Actual behavior:

pnpm install throws because of the empty license field.

Additional information:

  • node -v prints: v9.3.0
  • Windows, OS X, or Linux?: Linux

npm handles this situation just fine, but pnpm exits with an error. I tracked the error down to these lines in normalize-package-data which fails to check for a whitespace string before passing it to the spdx parser.

@zkochan
Copy link
Member

zkochan commented Mar 7, 2018

Can you publish such package to the npm registry?

@Tellan
Copy link
Author

Tellan commented Mar 7, 2018

It errors even when calling pnpm install in a package directory with an empty license, but here's a package anyway:

https://www.npmjs.com/package/pnpm-license-test

@zkochan
Copy link
Member

zkochan commented Jan 17, 2019

Seems to work as of v2.25.2

@zkochan zkochan closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants