Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm run swallows empty strings given as parameters #6594

Closed
deiga opened this issue May 26, 2023 · 1 comment · Fixed by #6871
Closed

pnpm run swallows empty strings given as parameters #6594

deiga opened this issue May 26, 2023 · 1 comment · Fixed by #6871

Comments

@deiga
Copy link

deiga commented May 26, 2023

pnpm version: 8.5.1

pnpm swallows empty strings from cli arguments, which breaks scripts that might have those

Code to reproduce the issue:

  1. Add a echo script to package.json => "echo":"echo",
  2. run the script pnpm echo "foo" "" "bar"

Expected behavior:

  • > echo "foo" "" "bar"
  • foo bar

Actual behavior:

  • > echo "foo" "bar"
  • foo bar

Additional information:

  • node -v prints: v16.16.0
  • Windows, macOS, or Linux?: maOS
@await-ovo
Copy link
Member

It seems to be caused here, not sure if this should be fixed, maybe we can just filter the empty string in params for install command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants