Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should not swallows empty string in params #6871

Merged
merged 4 commits into from
Jul 28, 2023
Merged

fix: should not swallows empty string in params #6871

merged 4 commits into from
Jul 28, 2023

Conversation

await-ovo
Copy link
Member

fix #6594

Also, currently pnpm install "" will report an error

$ pnpm install ""         
 ERR_PNPM_MISSING_PACKAGE_NAME  `pnpm add` requires the package name

that was fixed in this pr as well.

@await-ovo await-ovo requested a review from zkochan as a code owner July 27, 2023 10:34
@zkochan zkochan merged commit 32679f0 into pnpm:main Jul 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pnpm run swallows empty strings given as parameters
2 participants
@await-ovo @zkochan