feat: move .pnpm-lock.yaml to .pnpm/ #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aparajita @ExE-Boss I think now that there'll be a |
zkochan
changed the title
zkochan
added a commit
that referenced
this pull request
Sep 19, 2019
PR #2018 BREAKING CHANGE: node_modules/.pnpm-lock.yaml => node_modules/.pnpm/pnpm-lock.yaml
zkochan
force-pushed
the
move-meta-files
branch
from
3e4388d
to
ad9a77a
Compare
zkochan
added a commit
that referenced
this pull request
Sep 19, 2019
PR #2018 BREAKING CHANGE: node_modules/.pnpm-lock.yaml => node_modules/.pnpm/pnpm-lock.yaml
zkochan
force-pushed
the
move-meta-files
branch
from
ad9a77a
to
59b7d8b
Compare
PR #2018 BREAKING CHANGE: node_modules/.pnpm-lock.yaml => node_modules/.pnpm/pnpm-lock.yaml
zkochan
force-pushed
the
move-meta-files
branch
from
59b7d8b
to
c2e487c
Compare
ExE-Boss
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
I think doing this is a good idea, but I’ll wait for @aparajita.
|
A thought occurs, why is pnpm’s name duplicated in the file hierarchy, shouldn’t it just be: |
|
I guess |
zkochan
added a commit
that referenced
this pull request
Sep 21, 2019
zkochan
added a commit
that referenced
this pull request
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
node_modules/.pnpm-lock.yaml => node_modules/.pnpm/pnpm-lock.yaml
node_modules/.modules.yaml => node_modules/.pnpm/modules.yamlIt is pretty safe to move.pnpm-lock.yamlto.pnpm/pnpm-lock.yaml.I am not sure about.modules.yamlthough. There are two issues with moving.modules.yaml:1. previous versions of pnpm are reading this file and they can tell users that a newer version of pnpm was used to install the node_modules2. if we decide to make the virtual store location configurable (the
node_modules/.pnpmdir),.modules.yamlmay be used to store its custom location (related #1636)