feat: have if-present apply to recursive runs #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanmorley
force-pushed
the
recursive-if-present
branch
from
9252df1
to
8424541
Compare
zkochan
reviewed
May 1, 2020
Comment on lines
266
to
273
| await execa('pnpm', [ | ||
| 'install', | ||
| '-r', | ||
| '--registry', | ||
| REGISTRY, | ||
| '--store-dir', | ||
| path.resolve(DEFAULT_OPTS.storeDir), | ||
| ]) |
Comment on lines
315
to
322
| await run.handler({ | ||
| ...DEFAULT_OPTS, | ||
| ...await readProjects(process.cwd(), [{ namePattern: '*' }]), | ||
| dir: process.cwd(), | ||
| ifPresent: true, | ||
| recursive: true, | ||
| workspaceDir: process.cwd(), | ||
| }, ['this-command-does-not-exist']) |
There was a problem hiding this comment.
You could probably run this in the previous test case as well. That way, one case will test both scenarios.
zkochan
reviewed
May 1, 2020
zkochan
reviewed
May 1, 2020
| @@ -217,6 +227,15 @@ test('`pnpm recursive run` fails when run with a filter that includes all packag | |||
| version: '1.0.0', | |||
| }, | |||
| ]) | |||
|
|
|||
There was a problem hiding this comment.
You can add here a comment
t.comment('recursive run does not fail when if-present is true')
5600e21
to
90eb1dc
Compare
|
Thanks. There are also some linting errors. Run And add some changesets. Run |
zkochan
approved these changes
May 1, 2020
zkochan
pushed a commit
that referenced
this pull request
May 2, 2020
|
🚢 4.14.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these changes are correct.
I'm not sure whether the IF_PRESENT related functions /
consts / help text should move along with the typing.