Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start fixing issue #2707
code passes eslint, compiles, runs with success on project jsdomwhich is using yarn.lock to force versions, otherwise jsdom fails to compile
jsdom compile is passing, so my patch cant be too bad : ]
but maybe other projects fail to compile with this
pnpm import
TODO allow to set lockfile like
pnpm import [lockfile]
TODO dont run scripts after
pnpm import
, only afterpnpm install
import only creates the pnpm-lock.yaml file
maybe run install after import?
TODO why does
pnpm import
say 'Already up-to-date'?TODO tell the user what lockfile is imported
.... why make the deps-tree flat?
= pass versionsByPackageNames on recursion
not versionsByPackageNames[packageName].dependencies
npm lockfiles allow locking of top-level AND sub dependency versions
i also dont understand the manpage on limitations
my understanding was that pnpm can install different versions
in pnpm's nested (non-flat) node_modules tree
.... is needed to make eslint happy
see eslint rule @typescript-eslint/restrict-template-expressions
using 'foreign lockfile' as shortname for a non-pnpm lockfile
could use a better name. 'external lockfile'?