-
-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(publish): support "publishConfig.directory" field #3490
Conversation
a6c5e59
to
d3e4982
Compare
d3e4982
to
9e5402f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test
1f20516
to
31bc2e6
Compare
@zkochan I facing an issue, I was able to test this feature, and it works by looking at the logs (since npm execution stdio is being inherited), but I'm not able to spy that stdout programmatically, I did a search online and I couldn't find anything about inspecting an stdio inherit process |
after publishing the package, install it and check the contents. There are similar tests already in the project. |
31bc2e6
to
0a92b17
Compare
@zkochan I tried following some of the other tests doing the install and I wasn't able to make it work, I give up 😢, the feature is certainly doing it's job, the package in the publishConfig.directory is being published as it can be seen in the logs |
73f9a69
to
5251b68
Compare
5251b68
to
db1e830
Compare
db1e830
to
f8315b8
Compare
While testing this feature in v6.7.0 I realized there is something wrong, the cwd is set correctly, but not the npm publish arg 😢 This is weird, because in the tests everything worked as intended 🤔 |
Adding support for "publishConfig.directory" field, feature present in changesets changesets/changesets#428, and lerna: https://github.com/lerna/lerna/tree/main/commands/publish#publishconfigdirectory