-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(cli): add support for publishing from a subdirectory using publishConfig.directory
#428
Conversation
Hooray! All contributors have signed the CLA. |
🦋 Changeset is good to goLatest commit: f1a1f5a We got this. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Is this any different from what we do now? I fail to see the difference.
Could you link to their docs about this feature? Are there any tools handling it in the same way? |
@Andarist The difference is where do you run the
So there is a temporary And here's a reference for that: https://www.npmjs.com/package/@lerna/publish#publishconfigdirectory |
…ublishConfig.directory`
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
7cedb61
to
56cd7bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
=========================================
Coverage ? 77.84%
=========================================
Files ? 42
Lines ? 1255
Branches ? 301
=========================================
Hits ? 977
Misses ? 268
Partials ? 10
Continue to review full report at Codecov.
|
@Andarist resolved all comments :) |
Right, this matter for the publish alone though - it doesn't matter for the versioning step though. Maybe I've misunderstood your original comment somehow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm going to keep this open for a little bit more time so others have a chance to look at this as well.
The PR resolves this issue: #423
@Andarist