fix: update cmd should work normal when set empty string version #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireairforce
changed the title
fireairforce
changed the title
fireairforce
force-pushed
the
fix-outdated-with-non-string
branch
from
4b5b66f
to
b5f6abe
Compare
|
feel free to review it~ @zkochan |
zkochan
reviewed
Jan 17, 2022
| }, | ||
| devDependencies: { | ||
| 'pnpm-foo': '', | ||
| 'peer-c': '', |
There was a problem hiding this comment.
I didn't know this was possible. What does it mean? Is it the same as *? Does it work with Yarn/npm?
There was a problem hiding this comment.
works fine in yarn, this was a bug here, it will update the devPendencies(which pkg's version was a empty string '') to dependencies, it's a wrong behaviour before this pr fix...
There was a problem hiding this comment.
this works fine in yarn
zkochan
reviewed
Jan 17, 2022
Comment on lines
1
to
3
| /// <reference path="../../../typings/index.d.ts" /> | ||
| import './getSpecFromPackageManifest.test' | ||
| import './updateProjectManifestObject.test' |
There was a problem hiding this comment.
this whole file is not needed. It was needed when we used tape.
|
Please also create a changeset for pnpm, with a link to the closed issue. So that the release will create a nice release page like this: https://github.com/pnpm/pnpm/releases/tag/v6.26.1 |
|
done~ |
zkochan
reviewed
Jan 17, 2022
fireairforce
force-pushed
the
fix-outdated-with-non-string
branch
from
cc96c34
to
7daf24c
Compare
zkochan
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4196