Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prefer-symlinked-executables #5048

Merged
merged 3 commits into from Jul 18, 2022
Merged

feat: prefer-symlinked-executables #5048

merged 3 commits into from Jul 18, 2022

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jul 17, 2022

A new setting supported: prefer-symlinked-executables
When true, on Posix systems pnpm will create symlinks to executables in
node_modules/.bin instead of command shims.

This setting is true by default when node-linker is set to
hoisted.

close #4782

A new setting supported: `prefer-symlinked-executables`
When `true`, on Posix systems pnpm will create symlinks to executables in
`node_modules/.bin` instead of command shims.

This setting is `true` by default when `node-linker` is set to
`hoisted`.

close #4782
@zkochan zkochan requested a review from a team July 17, 2022 20:43
Copy link
Member

@gluxon gluxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@chengcyber
Copy link
Member

chengcyber commented Jul 18, 2022

Looks good to me. But im a little curious about the roadmap of this config, whether it will be default true in the future, or a pattern-like config for some packages, such as pnpm.preferSymlinkExecutableDependencies: [“foo“], or maybe a counter side: pnpm.preferCommandShimDependencies: [“foo“] ?

@zkochan
Copy link
Member Author

zkochan commented Jul 18, 2022

I don't think such complex configuration is needed for this.

@zkochan zkochan merged commit 28f0005 into main Jul 18, 2022
@zkochan zkochan deleted the fix/4782 branch July 18, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symlink for bin files when node-linker=hoisted
3 participants