feat: add pnpm.requiredScripts config #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengcyber
reviewed
Dec 19, 2022
| for (const chunk of packageChunks) { | ||
| await Promise.all(chunk.map(async (prefix: string) => | ||
| limitRun(async () => { | ||
| const pkg = opts.selectedProjectsGraph[prefix] | ||
| if (!pkg.package.manifest.scripts?.[scriptName]) { | ||
| if (requiredScripts.includes(scriptName)) { | ||
| throw new PnpmError('RECURSIVE_RUN_NO_SCRIPT', `Missing script "${scriptName}" in ${pkg.package.dir}`) |
There was a problem hiding this comment.
One observation is that this throws an error immediately in a async function, which means
- Non deterministic order
- Bad user experience to fix the errors
Let's say projects A, B are missing the target scripts:
- people may get missing script error for A, sometimes get missing script error for B.
- when a user get a missing script error for A, he/she fixes it and then run the same command again. He/She may encounter a missing script error for another project. This kind of experience feels a bit endless...
So, IMO, it will be better to print something like Missing script "${scriptName}" in packages: @my-company/A, @my-company/B. In this way, people can get all the projects miss the target script in one operation.
kenrick95
approved these changes
Dec 20, 2022
zkochan
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5569