fix(deploy): ensure that the deploy target is generated in the same directory

[await-ovo]

fix #6858

[zkochan]

What was the issue with dedupePeerDependents?

Is the modules directory issue covered with a test?

I am not sure why all module directories should be updated, I'll have to look into it.

[await-ovo]

What was the issue with dedupePeerDependents?

The original issue here should be related to pnpm --filter pattern install not working in dedupe-peer-dependents=true.

Is the modules directory issue covered with a test?

Yes, In this test, pnpm --filter project-1 deploy ./deploy will generate deploy/node_modules in the project root directory and sub-dir directory at the same time, this pr fixes it ~.

I am not sure why all module directories should be updated, I'll have to look into it.

Take pnpm filter project-1 deploy ./deployas an example, the modulesDir set here is only relative to project-1, which is ./deploy/node_modules. In the case of dedupe-peer-dependents=true by default, we will install dependencies for all projects, and eventually the dependencies of sub-dir/project-2 will be written to /sub-dir/deploy/node_modules during pnpm deploy.

So I updated the modulesDir of all projects here to ensure that the relative path is correct.

[zkochan]

It is not a good fix. The issue is happening because deploy should run on a single project but when dedupe-peer-dependnents it true, all projects are selected:

pnpm/pkg-manager/plugin-commands-installation/src/installDeps.ts

Lines 167 to 171 in 32679f0

	if (opts.dedupePeerDependents) {
	allProjectsGraph = opts.allProjectsGraph ?? createPkgGraph(allProjects, {
	linkWorkspacePackages: Boolean(opts.linkWorkspacePackages),
	}).graph
	} else {

The easiest fix would be to always set dedupe-peer-dependnents to true, when running install during deploy.

[await-ovo]

It is not a good fix. The issue is happening because deploy should run on a single project but when dedupe-peer-dependnents it true, all projects are selected:

I just noticed that even though dedupe-peer-dependents is set to false,deploy will installs the workspace root dependencies at the same time. Inside the repository here, we can see that ../../pruned/node_modules is generated at the same time after running pnpm --filter foo deploy ./pruned.

It looks like we need to set the modulesDir for each project separately, in addition to setting dedupe-peer-dependents to false.