Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for libgit2 1.8 #920

Merged
merged 5 commits into from
May 6, 2024

Conversation

How2PlayGithub
Copy link
Contributor

Fixed for libgit2:1.8.0-2

The error functions and enumeration values have been renamed for consistency. The giterr_ functions and values prefix have been renamed to be prefixed with git_error_; similarly, the GITERR_ constants have been renamed to be prefixed with GIT_ERROR_. The old enumerations and macros will be retained for backward compatibility for the foreseeable future.

https://github.com/libgit2/libgit2/blob/main/docs/changelog.md

@How2PlayGithub
Copy link
Contributor Author

I had this error today and found that I just needed to change it to giterr_clear for it make

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! It seems that libgit2 is not following SemVer... Just a nit, please keep the newline before the namespace end. Otherwise, it looks good to me.

src/Git2/Exception.cc Outdated Show resolved Hide resolved
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ken-matsui ken-matsui merged commit 97b43cb into poac-dev:main May 6, 2024
14 checks passed
ken-matsui added a commit that referenced this pull request Jul 21, 2024
Related to: #920,
#930

This is because they don't follow SemVer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants