Install Libtool in build script #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #40 With the merge of the read contract functionality `libtoolize` was needed for one of the dependencies. After testing the fix, I was able to successfully complete the deployment. Here is the temporary build with this fix: http://sokab-explorer-sokol-elb-1771258833.us-east-1.elb.amazonaws.com/en
KronicDeth
approved these changes
Jul 23, 2018
| @@ -59,6 +59,10 @@ if ! which git >/dev/null; then | |||
| log "Installing git.." | |||
| yum install -y --enablerepo=epel git >"$LOG" | |||
| fi | |||
| if ! which libtool >/dev/null; then | |||
| log "Installing libtool.." | |||
| yum install -y libtool >"$LOG" | |||
There was a problem hiding this comment.
Did you check if we should be getting libtool from the epel repo using --enablerepo=epel? If it is available in epel, we should use the epel version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
With the merge of the read contract functionality
libtoolizewas needed for one of the dependencies. After testing the fix, I was able to successfully complete the deployment.Here is the temporary build with this fix: http://sokab-explorer-sokol-elb-1771258833.us-east-1.elb.amazonaws.com/en