Add recommended metadata to Cargo.toml #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rust API guidelines recommend a set of metadata values: https://rust-lang-nursery.github.io/api-guidelines/documentation.html#c-metadata
|
There's also an optional " |
|
I think it's better to link home page to GitHub org page
…On Wed, Jul 4, 2018, 1:48 PM Andreas Fackler ***@***.***> wrote:
There's also an optional "homepage" link; not sure whether it would make
sense to link to e.g. https://poa.network/ from the crates.io page,
though.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#107 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAZ6tKvo6FeFyRkM8feMqJIH3tVC0Htbks5uDKuZgaJpZM4VCYzQ>
.
|
|
OK, then we don't have to add the " |
vkomenda
reviewed
Jul 5, 2018
Cargo.toml
Outdated
| @@ -2,6 +2,15 @@ | |||
| name = "hbbft" | |||
| version = "0.1.0" | |||
| authors = ["Vladimir Komendantskiy <komendantsky@gmail.com>"] | |||
There was a problem hiding this comment.
Should we add all of us individually, or rather a single POA email address?
There was a problem hiding this comment.
You are right, as the team grows, we might need to follow the example of other projects, e.g.,
authors = ["Parity Technologies <admin@parity.io>"]
There was a problem hiding this comment.
@igorbarinov: Is there some email address like that, which we should use as "the author"?
There was a problem hiding this comment.
I extended the authors list.
vkomenda
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust API guidelines recommend a set of metadata values:
https://rust-lang-nursery.github.io/api-guidelines/documentation.html#c-metadata
(See #108)