Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests for feature 'validate rpc' PR#99 #100

Merged
merged 5 commits into from
Aug 31, 2018

Conversation

dennis00010011b
Copy link

@dennis00010011b dennis00010011b commented Aug 31, 2018

Relates to #76

Added tests:
Custom Rpc
✓ switches to settings screen through menu 'Network -> Custom RPC' (139ms)
✓ error message if new Rpc url is invalid (999ms)
✓ error message if new Rpc url has no HTTP/HTTPS prefix (2383ms)
✓ error message if Rpc doesn't exist (2472ms)
✓ user can add valid custom rpc (13421ms)
✓ new added Rpc displayed in network dropdown menu (417ms)
✓ click button 'Delete' opens screen 'Delete Custom RPC' (1392ms)
✓ click button 'No' opens screen 'Settings' (392ms)
✓ user able to delete custom rpc (623ms)
✓ deleted custom rpc isn't displayed in 'Settings' screen (157ms)
✓ deleted custom rpc isn't displayed in network dropdown menu (3802ms)

@vbaranov vbaranov merged commit 37e65d1 into poanetwork:validate-rpc Aug 31, 2018
@ghost ghost removed the awaiting for review label Aug 31, 2018
@vbaranov vbaranov mentioned this pull request Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants