Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Validate custom RPC #99

Merged
merged 22 commits into from
Sep 10, 2018
Merged

(Fix) Validate custom RPC #99

merged 22 commits into from
Sep 10, 2018

Conversation

vbaranov
Copy link
Collaborator

Relates to #76

Validate custom RPC with HTTP GET request before adding it to the list.

Also,

  • fix styles for address value in the main screen
  • add RPC endpoint in parentheses to loader "Connecting to an unknown private network (RPC_ENDPOINT)"

@vbaranov
Copy link
Collaborator Author

@dennis00010011b please add to this PR update of e2e tests to support validation of custom RPC

@fvictorio
Copy link

If you add an invalid RPC, an error message appears. If you then change the URL to a valid one and click "Save", the network is saved but the error message is still there.

@vbaranov
Copy link
Collaborator Author

vbaranov commented Sep 7, 2018

If you add an invalid RPC, an error message appears. If you then change the URL to a valid one and click "Save", the network is saved but the error message is still there.

@fvictorio fixed

@vbaranov vbaranov merged commit b294f92 into develop Sep 10, 2018
@ghost ghost removed the awaiting for review label Sep 10, 2018
@vbaranov vbaranov deleted the validate-rpc branch September 10, 2018 16:13
@vbaranov vbaranov mentioned this pull request Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants