Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-1193 - send is deprecated in favor of request #421

Closed
ilanolkies opened this issue Nov 12, 2020 · 1 comment
Closed

EIP-1193 - send is deprecated in favor of request #421

ilanolkies opened this issue Nov 12, 2020 · 1 comment
Labels
ready for release

Comments

@ilanolkies
Copy link

If you are reporting a problem with Nifty Wallet, please include the following information:

What browser and version did you use?

Google Chrome latest

What operating system did you use?

MacOS

Do you have screenshots showing the problem?

Screen Shot 2020-11-12 at 19 19 02

What is your issue?

EIP-1193 specifies that Web3 providers should use request as function wrapper for RPCs. It also specifies that function send should be deprecated. This causes problems when handling both Metamask and Nifty support.

Refs:
@vbaranov vbaranov mentioned this issue Nov 13, 2020
Merged
@vbaranov
Copy link
Collaborator

Included into 5.2.0. Published.

@jessgusclark jessgusclark mentioned this issue Mar 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbaranov @ilanolkies