Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) New style for xDai network #192

Merged
merged 44 commits into from Jan 9, 2019

Conversation

gabitoesmiapodo
Copy link
Contributor

Closes #187

Description: Updated the dApp to make it able to support different styles, colors, etc. for different networks.

Fixed a few styling and layout issues here and there.

Added some standard components taken from other POA Network dApps, in hopes to have a more coherent and consistent ecosystem.

Hopefully improved responsive versions.

What is it: Update / new feature.

Additional Info: I'm attaching a few screen captures to know what to expect from this update.

Ballots section

localhost_3000_poa-dapps-voting laptop with mdpi screen
localhost_3000_poa-dapps-voting ipad
localhost_3000_poa-dapps-voting nexus 6p

New Ballot section

localhost_3000_poa-dapps-voting_new laptop with mdpi screen
localhost_3000_poa-dapps-voting_new ipad
localhost_3000_poa-dapps-voting_new nexus 6p

Mobile menu

localhost_3000_poa-dapps-voting_new nexus 6p 1

Loading component

localhost_3000_poa-dapps-voting_new laptop with mdpi screen

…utton / (add) component for main title / (add) component for navigation links /
* core:
  fix package.json
  Fix packages
  change versions of npm packages for adding to poa-test-setup as npm package
… input title component - (add) form textarea component
Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. screen shot 2019-01-05 at 22 17 47
  2. screen shot 2019-01-05 at 22 15 35
  3. screen shot 2019-01-05 at 22 09 39
  4. screen shot 2019-01-05 at 22 07 38
  5. screen shot 2019-01-05 at 22 06 04
  6. screen shot 2019-01-05 at 21 59 02

@vbaranov

- Footer logo should be clickable -> Fixed.
- Should be bolder... -> Fixed.
- New / "New Ballot" title -> Fixed.
- Only first letter should be capitalized -> Fixed.
- First letters should be capitalized -> Fixed.
- Wrong icon order. -> Fixed.
@gabitoesmiapodo
Copy link
Contributor Author

@vbaranov

  • Footer logo should be clickable -> Fixed.
  • Should be bolder... -> Fixed.
  • New / "New Ballot" title -> Fixed.
  • Only first letter should be capitalized -> Fixed.
  • First letters should be capitalized -> Fixed.
  • Wrong icon order. -> Fixed.

@varasev
Copy link
Contributor

varasev commented Jan 7, 2019

Please don't merge this yet. I'll review as well.

@gabitoesmiapodo
Copy link
Contributor Author

@varasev

Sure, no problem.

Copy link
Contributor

@varasev varasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's automatically scroll the page up when we click on All, Active, or To Finalize.

  2. When I click on New Ballot, I see the loading screen for a few seconds. On the previous version of DApp, there is no loading screen when clicking on New Ballot. Is there something new being loaded now?

  3. Long description of a ballot isn't fully displayed on small screens (I used Chrome's responsive mode to discover it).

@varasev
Copy link
Contributor

varasev commented Jan 8, 2019

  1. When I click on New Ballot, I see the loading screen for a few seconds. On the previous version of DApp, there is no loading screen when clicking on New Ballot. Is there something new being loaded now?

It seems the reason is that New Ballot button is not NavLink. Please make it use NavLink as other navigation links use (All, Active, and To Finalize).

@gabitoesmiapodo
Copy link
Contributor Author

@varasev

  • Let's automatically scroll the page up when we click on All, Active, or To Finalize. -> Done.

  • When I click on New Ballot, I see the loading screen for a few seconds. On the previous version of DApp, there is no loading screen when clicking on New Ballot. Is there something new being loaded now? It seems the reason is that New Ballot button is not NavLink. Please make it use NavLink as other navigation links use (All, Active, and To Finalize). -> Yes, you are right. Exchanged the link element for a NavLink. I did that too for the header and footer's logos, so everything should be smooth now.

  • Long description of a ballot isn't fully displayed on small screens (I used Chrome's responsive mode to discover it). -> Fixed.

@vbaranov vbaranov self-requested a review January 9, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants