Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Remove theoretical reentrancy from VotingTo._createBallot method and other enhancements #170

Merged
merged 1 commit into from Aug 22, 2018

Conversation

varasev
Copy link
Contributor

@varasev varasev commented Aug 22, 2018

  • (Mandatory) Description
    Removes theoretical reentrancy from VotingTo._createBallot function. Removes payable keyword from EternalStorageProxy contract. Removes excess interfaces for VotingTo* contracts. Fixes the replacement of EmissionFunds contract address in scripts/migrate/migrateAll.js script.

  • (Mandatory) What is it: (Fix), (Feature), or (Refactor)
    (Fix)

@varasev varasev merged commit 2cd364a into poanetwork:security-audit Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant