Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

[contract] Add statistics variables #68

Merged
merged 3 commits into from Sep 10, 2018
Merged

[contract] Add statistics variables #68

merged 3 commits into from Sep 10, 2018

Conversation

unjapones
Copy link
Contributor

Includes

  • Add totalUsers & totalBankAccounts stats variable to PoBA.sol (+ tests to blockchaing/test/poba.js).
  • Add LogSignerChanged event to PoBA.sol.

@unjapones
Add totalUsers stats variable to PoBA.sol.
813c1cc 
Update the corresponding test-contract methods.
@unjapones
Add totalBankAccounts to PoBA.sol
050c236 
Add the corresponding tests to test/poba.js.
@unjapones
Add LogSignerChanged event to PoBA contract.
52fdcd7
@unjapones unjapones self-assigned this Sep 10, 2018
@ghost ghost added the in progress label Sep 10, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 207

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 41.787%
Totals Coverage Status
Change from base Build 206: 0.4%
Covered Lines: 252
Relevant Lines: 552
💛 - Coveralls

@unjapones unjapones merged commit 0392d76 into poanetwork:master Sep 10, 2018
@ghost ghost removed the in progress label Sep 10, 2018
@unjapones unjapones deleted the issue-#56 branch September 10, 2018 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phahulin phahulin phahulin approved these changes

Assignees

@unjapones unjapones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unjapones @coveralls @phahulin