Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

Add missing tests for new JS files in UI. #76

Merged
merged 11 commits into from Sep 24, 2018
Merged

Add missing tests for new JS files in UI. #76

merged 11 commits into from Sep 24, 2018

Conversation

unjapones
Copy link
Contributor

@unjapones unjapones commented Sep 18, 2018 •
edited

Closes #71

Increase coverage to an overall of 80%.

Includes

  • Missing specs for a function in the main server's controller.
  • Abstract and move out contracts & server API from UI component, to make them easy to mock and maintain.
  • Renaming of main UI components, for example: BankAccountList => PlaidBankAccountsList.
  • Add basic tests on the UI to check that components render ok (either mounted or shallowed rendered).

@unjapones
Move UI component tests to their respective path.
8fd7786 
Add __tests__ inside each UI folder accordingly.
@unjapones
Fix paths after UI tests moves.
aef0013 
Add missing layout __tests__ files.
@unjapones
Skip fronted/ui/src/styles in coverage report.
56304ef
@unjapones
Add basic frontend/ui/pages tests.
00e842f 
Add missing className property to identify rendered content.
@unjapones unjapones self-assigned this Sep 18, 2018
@coveralls
Copy link

coveralls commented Sep 18, 2018 •
edited

Pull Request Test Coverage Report for Build 224

  • 71 of 112 (63.39%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+38.3%) to 80.084%
Changes Missing Coverage Covered Lines Changed/Added Lines %
frontend/src/App.js 0 2 0.0%
frontend/src/ui/containers/PlaidBankAccounts.js 28 33 84.85%
frontend/src/ui/containers/VerifiedBankAccounts.js 24 30 80.0%
frontend/src/PoBAServer.js 2 9 22.22%
frontend/src/PoBAContract.js 2 23 8.7%
Totals Coverage Status
Change from base Build 216: 38.3%
Covered Lines: 334
Relevant Lines: 416
💛 - Coveralls

@unjapones
Move out contract & backend logic from UI components.
0e2547b 
Move out contract & backend logic from UI components (add PoBAContract & 
PoBAServer modules).
Split pages into containers to improve testeability.
@unjapones
Fix eslint warnings.
67ef371
@unjapones
Improve PlaidButton & ErrorPage coverage.
853dd31 
Ignore frontend's main index.js & registerServiceWorker.js in coverage
report.
@unjapones
Add accounts.controller getIdentity spec/test.
6b3dc6b
@unjapones
Rename ui components to better reflect their purpose.
caadfe9
phahulin
phahulin approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@phahulin phahulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@unjapones unjapones merged commit 4a49d11 into poanetwork:master Sep 24, 2018
@unjapones unjapones deleted the issue-#71 branch September 24, 2018 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phahulin phahulin phahulin approved these changes

Assignees

@unjapones unjapones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unjapones @coveralls @phahulin