Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

(Improvement) Remove bank account number, store person's name #81

Merged
merged 14 commits into from Nov 25, 2018
Merged

(Improvement) Remove bank account number, store person's name #81

merged 14 commits into from Nov 25, 2018

Conversation

unjapones
Copy link
Contributor

Closes #57 .

  • Store the person's name: what Plaids's Identity endpoint returns (if there is more than one name, they are sepparated by a comma char).
  • Adapt the UI accordingly: only one item will show in the page that renders after Plaid widget appears (and the correct user/pass/etc are entered).
  • Remove the corresponding code from the contract and the backend.

Demo:

poba_issue-57

@unjapones
Fix "A <Router> may have only one child element".
b31a43e
@unjapones
Make general layout responsive.
bb87afa 
Use Bootstrap breakpoints.
Make the footer looks similar to PoPA in narrower resolutions.
@unjapones
Make main navigation buttons responsive.
89c8cb0
@unjapones
Make the bank account items responsive.
631e514
@unjapones
Make the text headers responsive.
9adfb10
@unjapones
Fix failing frontend unit test.
86ac170
@unjapones
Fix IndexPage buttons overlapping between md & lg.
7912e01
@unjapones
Fix Loading position in narrower resolutions.
56e95a3
@unjapones
Remove unused import & fix ES lint error.
ffb0936
@unjapones
Remove bank account number rom PoBA.sol.
8d91f54 
Rename some methods from PoBA.sol to make them more explicit.
Fix test/poba.js based on changes made in PoBA.sol.
@unjapones
Change verification to having at least one bank account.
3397e63 
Add identity names to GET accounts/bank-accounts/$PLAIDTOKEN.
Update the verified logic in PlaidBankAccounts.
Remove the bank account number from fronted.
Update PoBAContract & PoBAServer according to bank account number 
removal.
@unjapones
Hide error/no bank accounts text while loading.
b58872e 
Hide error/no bank accounts text while the overlay (loading) is present 
on PlaidBankAccounts & VerifiedBankAccounts.
@unjapones
Remove unused route from routers/acounts.js.
f709962
@unjapones
Add las PoBA.json artifact build.
46e8bd3
@unjapones unjapones self-assigned this Nov 23, 2018
@ghost ghost added the in progress label Nov 23, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 232

  • 32 of 44 (72.73%) changed or added relevant lines in 13 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.4%) to 83.224%
Changes Missing Coverage Covered Lines Changed/Added Lines %
frontend/src/App.js 0 2 0.0%
frontend/src/PoBAServer.js 0 3 0.0%
frontend/src/ui/containers/PlaidBankAccounts.js 13 16 81.25%
frontend/src/PoBAContract.js 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
frontend/src/ui/containers/PlaidBankAccounts.js 1 80.39%
frontend/src/ui/containers/BackButton.js 1 66.67%
Totals Coverage Status
Change from base Build 228: 1.4%
Covered Lines: 324
Relevant Lines: 392
💛 - Coveralls

@phahulin phahulin merged commit ff4594c into poanetwork:master Nov 25, 2018
@ghost ghost removed the in progress label Nov 25, 2018
@unjapones unjapones deleted the remove-bank-account-number branch November 26, 2018 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phahulin phahulin phahulin approved these changes

Assignees

@unjapones unjapones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unjapones @coveralls @phahulin