Fix condition in confirmation code generation. Fixes #64

web-dapp/server-lib/generate_code.js

@@ -15,6 +15,10 @@ function generate_code() {
                 continue;
             }
             code += config.code_symbols[b%config.code_symbols.length];
+
+            if (code.length >= config.code_length) {
+                break;
+            }
         }
     } while (code.length < config.code_length);
 

web-dapp/test/server/generate_code.spec.js

@@ -0,0 +1,22 @@
+'use strict';
+
+const generate_code = require('../../server-lib/generate_code');
+const config = require('../../server-config');
+
+const TRIES = 1e4;
+
+describe('Confirmation code', () => {
+    it('cc length should be equal to the one in config', () => {
+        var pass = true;
+
+        for (let i = 0; i < TRIES; i++) {
+            let code = generate_code();
+            if (code.length !== config.code_length) {
+                pass = false;
+                break;
+            }
+        }
+
+        return expect(pass).toEqual(true);
+    });
+});