This repository has been archived by the owner on Jun 29, 2020. It is now read-only.
(Feature) Show spinner when confirming and removing addresses #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After confirming or removing an address, wait for the transaction to be mined before hiding the spinner.
This is not a big change, but it seems to add some level of async that made a lot of test fail. I added a bunch of
setTimeout
s to make them pass (so that the expects are called after every async funtion was called), but I'm not a fan of this solution. Please let me know if you know a better way to do this.