Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

(Refactor) License from package.json should reference LICENSE #195

Merged
merged 2 commits into from Jul 3, 2018

Conversation

phahulin
Copy link
Contributor

@phahulin phahulin commented Jul 1, 2018

  • What is it? (leave one option)

    • (Refactor) of existing code (no functionality change)
  • What was the root cause of the problem originally / what feature was missing?
    License from package.json (MIT) does not match license from LICENSE file (GPLv3)

  • How does this pull request solve it (in broad terms)?
    Make package.json reference LICENSE file

  • Does it close any open issues?
    Closes (Question) Why are license notices different in package.json and LICENSE? #194

@ghost ghost assigned phahulin Jul 1, 2018
@ghost ghost added the in progress label Jul 1, 2018
@coveralls
Copy link

coveralls commented Jul 1, 2018

Pull Request Test Coverage Report for Build 616

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 79.707%

Totals Coverage Status
Change from base Build 612: 0.06%
Covered Lines: 1029
Relevant Lines: 1272

💛 - Coveralls

@phahulin phahulin merged commit cdbe618 into master Jul 3, 2018
@ghost ghost removed the in progress label Jul 3, 2018
@phahulin phahulin deleted the phahulin-patch-1 branch July 3, 2018 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Question) Why are license notices different in package.json and LICENSE?
3 participants