Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed docker-compose file. #113

Closed
wants to merge 16 commits into from
Closed

Changed docker-compose file. #113

wants to merge 16 commits into from

Conversation

VladimirNovgorodov
Copy link

No description provided.

akolotov and others added 16 commits October 9, 2018 17:07
@akolotov
Merge pull request omni#96 from poanetwork/develop
84432b8 
Merge develop to master branch
@andogro
test parameter clarification
5f353e8
@andogro
clarify test instructions
c2a290f
@akolotov
Merge pull request omni#104 from andogro/ag-update-test-parameters
8583bf2 
test parameter clarification
@VladimirNovgorodov
I have set docker restart on always instead on-failure, set rabbit:3 …
ea4f032 
…instead rabbit:3-management. Added files to .dockerignore.
@VladimirNovgorodov
Merge branch 'master' of github.com:VladimirNovgorodov/token-bridge
e66069e
@VladimirNovgorodov
Changed the bridge container restart policy to 'on-failure', the redi…
cb4b84c 
…s and rabbitmq container restart policy to 'unless-stoped'
@VladimirNovgorodov
Changed rabbitmq:3-managment to rabbitmq:3
e489261
@VladimirNovgorodov
Changed compose file
2ca0734
@VladimirNovgorodov
Changed docker-compose file
66c84ad
@VladimirNovgorodov
Test privateKeyToAddress
0ce0210
@VladimirNovgorodov
Changed default Validator_address
6b532c0
@VladimirNovgorodov
Update docker-compose.yml
46a94ea
@VladimirNovgorodov
Changed default validator address2
3b7d9f2
@VladimirNovgorodov
Changed default validator address2
2ec1550
@VladimirNovgorodov
Remove privateKeyToAddress.js
0ad57b4
@ghost ghost added the review label Nov 2, 2018
@akolotov
Copy link
Collaborator

akolotov commented Nov 5, 2018 •
edited
Loading

@patitonar @fvictorio please take a look at this PR

@pertsev
Copy link

pertsev commented Nov 5, 2018

@VladimirNovgorodov Please, add CPU and RAM limits for containers.

patitonar
patitonar reviewed Nov 6, 2018
View reviewed changes
.dockerignore
@@ -1,3 +1,11 @@
node_modules
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think node_modules should be ignored. I see there was a similar conversation on this comment #109 (comment)

@akolotov
Copy link
Collaborator

akolotov commented Nov 6, 2018

@VladimirNovgorodov could you share a forecast when the comments raised in this PR are addressed?
We need to provide responses on the issues found during the security audit on this week. Is it possible?

@phahulin, fyi

@VladimirNovgorodov
Copy link
Author

Yes. I'm working on it.

@VladimirNovgorodov
Copy link
Author

VladimirNovgorodov commented Nov 8, 2018 •
edited
Loading

@VladimirNovgorodov Please, add CPU and RAM limits for containers.

Docker-compose version 3 that we use only supports these limits in swarm mode. https://forums.docker.com/t/memory-limit-in-version-3-compose-files-without-using-swarm/37864.
In this case, I need to know if we can use Docker-compose file version 2 or maybe some other options.

@ArseniiPetrovich ArseniiPetrovich mentioned this pull request Nov 13, 2018
Closed
@patitonar
Copy link

@VladimirNovgorodov should we close this PR in favor of #116 ?

@phahulin
Copy link

Yes

@phahulin phahulin closed this Nov 13, 2018
@ghost ghost removed the review label Nov 13, 2018
@ArseniiPetrovich ArseniiPetrovich mentioned this pull request Dec 11, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patitonar patitonar patitonar left review comments

@fvictorio fvictorio Awaiting requested review from fvictorio

@akolotov akolotov Awaiting requested review from akolotov

Assignees

@VladimirNovgorodov VladimirNovgorodov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VladimirNovgorodov @akolotov @pertsev @patitonar @phahulin @andogro