Change isRequired to accept booleans and zero as valid values

poanetwork · Apr 11, 2018 · b795178 · b795178
1 parent 2855e21
commit b795178
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/utils/validations.js b/src/utils/validations.js
@@ -36,7 +36,7 @@ export const isAddress = (errorMsg = VALIDATION_MESSAGES.ADDRESS) => (value) =>
 }
 
 export const isRequired = (errorMsg = VALIDATION_MESSAGES.REQUIRED) => (value) => {
-  const isValid = !!value
+  const isValid = value !== '' && value !== null && value !== undefined
   return isValid ? undefined : errorMsg
 }
 

diff --git a/src/utils/validations.spec.js b/src/utils/validations.spec.js
@@ -140,9 +140,9 @@ describe('isRequired', () => {
     { value: 'undefined', errorMessage: undefined, expected: undefined },
     { value: 'null', errorMessage: undefined, expected: undefined },
     { value: 'false', errorMessage: undefined, expected: undefined },
-    { value: false, errorMessage: undefined, expected: VALIDATION_MESSAGES.REQUIRED },
+    { value: 0, errorMessage: undefined, expected: undefined },
+    { value: false, errorMessage: undefined, expected: undefined },
     { value: undefined, errorMessage: undefined, expected: VALIDATION_MESSAGES.REQUIRED },
-    { value: 0, errorMessage: undefined, expected: VALIDATION_MESSAGES.REQUIRED },
     { value: null, errorMessage: undefined, expected: VALIDATION_MESSAGES.REQUIRED },
     { value: '', errorMessage: undefined, expected: VALIDATION_MESSAGES.REQUIRED },
     { value: '', errorMessage: 'Personalized error message', expected: 'Personalized error message' },