Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) Add validation to decimal : if field is empty #634

Closed
dennis00010011b opened this issue Feb 27, 2018 · 4 comments
Closed

(Bug) Add validation to decimal : if field is empty #634

dennis00010011b opened this issue Feb 27, 2018 · 4 comments
Assignees

Comments

@dennis00010011b
Copy link

dennis00010011b commented Feb 27, 2018

Related #632

Problem:

User able to proceed with wizard if decimal field is empty. As a result deployment can't be finished.

If you are reporting a problem with Token Wizard, please include the following information:

Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)

Kovan, Rinkeby

If you were able to create it, what is the URL of your crowdsale?

*weren't able *

Do you have screenshots showing the problem?

screenshot from 2018-02-27 12-31-09
screenshot from 2018-02-27 12-33-45
wizard.poa.network-1519763968231.log

Do you see errors in the dev console? If yes, please include a screenshot

To open the dev console in Google Chrome, press F12, or go to View -> Developer -> Developer Tools, and open the Console tab

If you see errors, please right click on them and "Save as..". Zip saved file and attach it to the Issue.

wizard.poa.network-1519763968231.log


@dennis00010011b dennis00010011b changed the title (Bug) Add validation if decimal field is empty (Bug) Add validation to decimal : if field is empty Feb 27, 2018
@fernandomg
Copy link
Contributor

@dennis00010011b I couldn't reproduce it in production.

@dennis00010011b
Copy link
Author

@fernandomg It still possible if user return back from step 3. Then decimal field is empty but user can click button 'Continue and proceed.
#635

@fernandomg
Copy link
Contributor

@dennis00010011b oh, I see. So this should be solved as part of the solution of #637 then.

@fernandomg fernandomg self-assigned this Apr 9, 2018
@fernandomg
Copy link
Contributor

This bug was fixed as part of #705

@ghost ghost removed the to do label Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants