Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token wizard crowdsale creation does not call metamask #632

Closed
Febrero opened this issue Feb 27, 2018 · 17 comments
Closed

Token wizard crowdsale creation does not call metamask #632

Febrero opened this issue Feb 27, 2018 · 17 comments
Assignees

Comments

@Febrero
Copy link

Febrero commented Feb 27, 2018

If you are reporting a problem with Token Wizard, please include the following information:

Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)

Kovan, Rinkeby, Sokol

If you were able to create it, what is the URL of your crowdsale?

not able to create. After i click to create crowdsale it keeps on the same window and doesnt do anything.
image

Do you have screenshots showing the problem?

Many. Metamask is working fine (prove from mew)
image

Also there is an error on the dev mode:
image

Logfile
wizard.poa.network-1519755306821.log

Do you see errors in the dev console? If yes, please include a screenshot

see above

To open the dev console in Google Chrome, press F12, or go to View -> Developer -> Developer Tools, and open the Console tab

If you see errors, please right click on them and "Save as..". Zip saved file and attach it to the Issue.

Your answer

Also i have been able to create crowdsales in the past. Please see below a list of crowdsale contracts i have created on the test network /kovan

image

@vbaranov
Copy link
Collaborator

@Febrero What is your crowdsale parameters?

@Febrero
Copy link
Author

Febrero commented Feb 27, 2018

ok i know what the problem is.

so when i create the crowdsale like this it works:
image

image

image

if i add the contract creator address to the reserved tokens it breaks.

image

image

The problem is with the contract creator address being add to the reserved tokens.

@Febrero
Copy link
Author

Febrero commented Feb 27, 2018

how can this be fixed?

@dennis00010011b
Copy link

@Febrero
Looks like decimals field is empty . It may be reason why deployment failed. See #634

@Febrero
Copy link
Author

Febrero commented Feb 27, 2018 via email

@Febrero
Copy link
Author

Febrero commented Feb 27, 2018

The problem is if you try to add the contract creator address to reserve tokens.

Can you try? With the address your creating the contract also add it to the reserved tokens and assign it a token number, for example, 1000000

Then put the rest of the parameters as you please and see if it works.

In my case it did not work.

@dennis00010011b
Copy link

@Febrero I can't reproduce it

@Febrero
Copy link
Author

Febrero commented Feb 27, 2018

i did input 18 decimals:
image

then click continue (notice how the contract owner has reserved 10000000
image

amounts
image

if i go back the decimals disappeared
image

@Febrero
Copy link
Author

Febrero commented Feb 27, 2018

if i click continue it takes me to the last screen but nothing happens

@Febrero
Copy link
Author

Febrero commented Feb 27, 2018

im testing in kovan

@Febrero
Copy link
Author

Febrero commented Feb 28, 2018

@dennis00010011b were you able to reproduce now?

It's not working at all for me now. Something has definitely changed as this was working weeks ago.

@vbaranov
Copy link
Collaborator

I reproduced the problem.
It happens to me with 10000000 rate. oneTokenInETH is incorrectly calculated:
https://github.com/poanetwork/token-wizard/blob/master/src/stores/utils.js#L100.
@fernandomg @fvictorio please take a look

@Febrero
Copy link
Author

Febrero commented Feb 28, 2018

@vbaranov thanks Victor.

Do you know when will it get fixed, more or less? I'm not entirely sure about the seriousness, hence my question.

Thanks again

@vbaranov
Copy link
Collaborator

There is no ETA for this issue. We will resolve it ASAP. Follow this issue for resolution. Btw, there will be no error, if you'll use less rate.

@Febrero
Copy link
Author

Febrero commented Feb 28, 2018

Absolutely.

I have tested with a less rate and i confirm it's working. Thanks again Victor.

@ghost ghost assigned fernandomg Feb 28, 2018
@ghost ghost added in progress and removed to do labels Feb 28, 2018
@fernandomg
Copy link
Contributor

fernandomg commented Feb 28, 2018

@Febrero @vbaranov I'm working on this issue.

I'm taking the chance to replace the rate input type from number to text, so we are able properly handle big (or really small: 1e-18) numbers, I'm working with BigNumber library (https://github.com/MikeMcl/bignumber.js) to do so.

I've managed to properly work with numbers up to 1e18, and deploy properly.

Tomorrow will be pushing the PR for this issue, after fixing rate validation and crowdsale/invest pages handling of rate value.

@Febrero
Copy link
Author

Febrero commented Feb 28, 2018

@fernandomg muchas gracias Fernado.

Awesome, thank you so much for the explanation and for swift resolution. Will wait for your
--commit.

fernandomg added a commit that referenced this issue Mar 6, 2018
# Conflicts:
#	src/stores/TierStore.js
fernandomg added a commit that referenced this issue Mar 6, 2018
vbaranov added a commit that referenced this issue Mar 11, 2018
fernandomg added a commit that referenced this issue Mar 12, 2018
@ghost ghost removed the awaiting for review label Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants