(Refactor) Of method getOwnerApplicationsInstancesForProxy #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- makes use of async/await syntax - sorts the result of contracts from newest to oldest
ghost
added
the
dennis00010011b
approved these changes
Jul 14, 2018
vbaranov
reviewed
Jul 16, 2018
| resolve() | ||
| const contracts = [] | ||
|
|
||
| for (const execID of execIDs) { |
There was a problem hiding this comment.
@fernandomg if I'm not wrong, in this case, smart-contracts' functions' execution will be made in a sequence, instead of parallel calls (from the current implementation). Thus, suggested implementation is slower for the number of proxy addresses greater then 1, isn't it? What are the benefits of suggested implementation?
There was a problem hiding this comment.
You're completely right, there's no benefit from my suggestion. My main idea was to make it more readable, but there's no performance benefit from it. I'll just close it.
Thank you!
Black Duck Security ReportBranch 2.0 has no Black Duck results, and could not be compared to #1046. Analyze branch 2.0 to get a change comparison. Removed ComponentsMedium Risk: 156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
getOwnerApplicationsInstancesForProxyCheck the discussion about this refactor for reference