(Fix) Investors incorrect max cap #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevents adding more addresses if the sum of the maxCaps exceeds the tiers' supply
- triggers an error for maxCap if it exceeds the remaining tier's supply - prevent displaying error messages if field wasn't modified yet - update maxCap validation if supply has been modified
- Validate supply against sum of whitelist's maxCap - Make validation active only when whitelist is enabled - Fix warning message when trying to read an array index out of bound
- used bigNumber's eq() when === cannot be used - removed unused variables - replaced == with === - disabled linting warnings - stepTwo/index.js:17 - DeploymentStore.js:80 - blockchainHelpers.js:380
|
@fernandomg
Expected result:
Actual result:
|
|
@dennis00010011b that was quick! thanks for the catch, will review it |
Black Duck Security ReportMerging #1072 into 2.0 will not change security risk. Removed ComponentsClean: 2 |
|
Ok, so after reviewing the different scenarios that will arise with this PR and have a chat with @vbaranov. It was decided to close this PR and create a new solution for #1067, which is #1067 (comment) |
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1067
This PR fixes all the related issues with whitelisted addresses and tier's supply. Scenarios that I took into account for both strategies (MintedCapped and DutchAuction):
maxCapof[100, 200, 300]ifsupplyis400, then only the first two addresses will be added.supplyvalue will be validated against the sum of themaxCaps. It should not be less than themaxCapsum.managescreensupplycannot be edited, so whitelist addresses will be checked.Note
The scenario that I didn't fix, due to the complexity of the fix itself (it would require several modifications and would be better to address it in a separate PR), has to be with
managescreen and an address values modification.As you can see in the screenshot
Despite having
1011tokens available, and requiring only28extra tokens to change1972to2000, it's giving the error as it considers that the address is new and not a modification of an existing one.Also: