Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Proxy contracts files (.sol, .abi & .bin) #1109

Merged
merged 8 commits into from Aug 28, 2018
Merged

(Feature) Proxy contracts files (.sol, .abi & .bin) #1109

merged 8 commits into from Aug 28, 2018

Conversation

fernandomg
Copy link
Contributor

Closes #1036

A bash script was created to generate the files for the proxy contracts in TW, from source stored in submodule auth-os-applications

  • To execute it with the current submodule commit:
    • ./scripts/generateProxyContracts.sh
  • To execute it from a particular commit in the submodule:
    • ./scripts/generateProxyContracts.sh 1234567
    • where 1234567 is the commit hash

It was added as the last step in the build process (npm run build)

@fernandomg
Remove static contracts files
9151160
@fernandomg
Create scripts to generate Proxy contracts from source stored in the …
abcccde 
…`auth-os-application` submodule

- To execute it with the current submodule:
  - `./scripts/generateProxyContracts.sh`
- To execute it from a particular commit in the submodule:
  - `./scripts/generateProxyContracts.sh 1234567`
  - where `1234567` is the commit hash
@fernandomg
Update build script
cf6891b 
 - add generateProxyContracts.sh script
 - fix linting issues
@fernandomg fernandomg self-assigned this Aug 24, 2018
@vbaranov
Copy link
Collaborator

@fernandomg maybe, let's add it also to npm run start ?

@dennis00010011b
Copy link

dennis00010011b commented Aug 27, 2018 •
edited

@fernandomg
In this PR scripts for e2e tests don't work anymore :
npm run e2eMintedWhitelist, npm run e2eMintedMincap, npm run e2eDutchWhitelist, npm run e2eDutchWhitelist because contracts don't deploy. Could you please look at it?

@mariano-aguero
Copy link
Contributor

@fernandomg
There are problems when executing the transactions. The branch e2e, I think it is not properly updated (to use locally with ganache). With ropsten there is another error

Ropsten
screenshot_20180827_090414

Ganache
screenshot_20180827_083257

mariano-aguero
mariano-aguero suggested changes Aug 27, 2018
View reviewed changes
Copy link
Contributor

@mariano-aguero mariano-aguero left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transactions do not work

@fernandomg
Copy link
Contributor Author

@mariano-aguero please check now. It should be working properly for ropsten and with ganache.

@dennis00010011b
Copy link

dennis00010011b commented Aug 27, 2018 •
edited

@fernandomg @mariano-aguero
Now it works with Ropsten and ganache. But e2etests are still failed
https://travis-ci.org/poanetwork/token-wizard/builds/421193879?utm_source=github_status&utm_medium=notification

@ghost ghost assigned dennis00010011b Aug 27, 2018
@vbaranov vbaranov merged commit 119551a into 2.0 Aug 28, 2018
@vbaranov vbaranov deleted the proxy-contracts-#1036 branch August 28, 2018 10:27
@ghost ghost removed the awaiting for review label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariano-aguero mariano-aguero mariano-aguero approved these changes

@vbaranov vbaranov vbaranov approved these changes

@dennis00010011b dennis00010011b dennis00010011b approved these changes

Assignees

@fernandomg fernandomg

@dennis00010011b dennis00010011b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fernandomg @vbaranov @dennis00010011b @mariano-aguero