Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) There is no Proxy contract address in zip archive (Minted capped only) #1152

Merged
merged 2 commits into from Sep 26, 2018

Conversation

mariano-aguero
Copy link
Contributor

@mariano-aguero mariano-aguero commented Sep 24, 2018

Closes #1150

I try to reproduce the error in the sokol network without success
I think the crowdsale of the problem is using exec-id , and is not proxy
Here is the line where the logical decision is made

https://github.com/poanetwork/token-wizard/blob/2.0/src/components/stepFour/utils.js#L994

Can you checked @dennis00010011b ?
If you find a problem, can you make a comment with the steps to reproduce it?

Regards

@mariano-aguero
Copy link
Contributor Author

I add a screenshot of the file
screenshot_20180924_174838

@dennis00010011b
Copy link

@mariano-aguero I can't reproduce it too for Minted.
But for Dutch file contains execution ID instead proxy address
screen shot 2018-09-24 at 1 57 43 pm

@BlackDuckCoPilot
Copy link

Black Duck Security Report

Merging #1152 into 2.0 will not change security risk.

Click here to see full report

@coveralls
Copy link

coveralls commented Sep 25, 2018

Pull Request Test Coverage Report for Build 3162

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 19.717%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/stepFour/utils.js 0 1 0.0%
Totals Coverage Status
Change from base Build 3143: 0.01%
Covered Lines: 884
Relevant Lines: 3847

💛 - Coveralls

@mariano-aguero
Copy link
Contributor Author

@dennis00010011b

I can't reproduce it too for Minted.

I think is an old contract

But for Dutch file contains execution ID instead proxy address

That is maybe a bug, for Dutch File must contain proxy address? Is ok that ?

@dennis00010011b
Copy link

dennis00010011b commented Sep 25, 2018

@mariano-aguero
Issue is reproducible, actual both for Minted and Dutch.
Issue isn't reproducible if it isn't first crowdsale that has created in current build.

Steps:

  1. Clone token-wizard repo to local machine

  2. Execute commands:

  • git submodule update --init --recursive --remote
  • cp .env.example .env
  • npm run start
  1. Create crowdsale(Minted or Dutch) with any parameters
  2. Proceed until Publish page
  3. Download and observe Auth-os_addresses.txt file

Expected result:

  • file should contain proxy address

Actual result:

  • file contains execution ID
  • file contains correct data if it isn't first crowdsale that has created in current build.

screen shot 2018-09-25 at 4 19 56 am

@mariano-aguero
Copy link
Contributor Author

I cant reproduce the problem with this steps, I suggested the creation of a video with all the steps that are made

@dennis00010011b
Copy link

dennis00010011b commented Sep 25, 2018

@mariano-aguero
video https://www.useloom.com/share/08d0ee96022a4f9695c89f7c75b500bb

I corrected step 2 #1152 (comment)

2. Execute commands:
  - git submodule update --init --recursive --remote
  - cp .env.example .env
  - npm run start

@mariano-aguero
Copy link
Contributor Author

@dennis00010011b

Can you check it again?
Please try to test it in private mode with your browser

@fernandomg fernandomg merged commit a14b6b2 into 2.0 Sep 26, 2018
@ghost ghost removed the awaiting for review label Sep 26, 2018
@fernandomg fernandomg deleted the issue#1150 branch September 26, 2018 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants