Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) Dutch -Step3: allowed to add whitelist if the supply field is empty #1234

Conversation

mariano-aguero
Copy link
Contributor

Closes #1233

@mariano-aguero
Copy link
Contributor Author

@dennis00010011b

Check if this issue #1183 is reproducible in this branch.

If this is solved, I think we should close that issue.
The design branch will replace the branch 2.0 in the next days and it is not worth the effort to solve it in the branch 2.0

@coveralls
Copy link

coveralls commented Nov 26, 2018

Pull Request Test Coverage Report for Build 3588

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 34.399%

Totals Coverage Status
Change from base Build 3576: 0.08%
Covered Lines: 1693
Relevant Lines: 4781

💛 - Coveralls

@dennis00010011b
Copy link

@mariano-aguero
Still possible to add whitelist without supply
Steps:

  1. Go to Step3
  2. Fill out Supply
  3. Enable whitelist
  4. Clear Supply
  5. Add whitelist

Expected result:

  • if supply empty then whitelist container should disappear and whitelist enabled flag should be No (see how it works for Minted startegy)

screen shot 2018-11-26 at 08 28 42

@mariano-aguero
Copy link
Contributor Author

Still possible to add whitelist without supply
Steps:

  • Go to Step3
  • Fill out Supply
  • Enable whitelist
  • Clear Supply
  • Add whitelist

Expected result:
if supply empty then whitelist container should disappear and whitelist enabled flag should be No (see how it works for Minted startegy)

@dennis00010011b
Ok, thats another scenario. Fixed in the previous commit

Thanks

@dennis00010011b
Copy link

@mariano-aguero
Possible to add whitelist if tier's supply more than total supply and error warning is displayed
screen shot 2018-11-26 at 09 33 24

@mariano-aguero
Copy link
Contributor Author

@dennis00010011b

Possible to add whitelist if tier's supply more than total supply and error warning is displayed

Fixed

Copy link

@gabitoesmiapodo gabitoesmiapodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is fine.

@gabitoesmiapodo gabitoesmiapodo merged commit a62101e into integration/#1082-new-design Nov 27, 2018
@ghost ghost removed the awaiting for review label Nov 27, 2018
@gabitoesmiapodo gabitoesmiapodo deleted the 1233-bug-dutch--step3-allowed-to-add-whitelist-if-the-supply-field-is-empty branch November 27, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants