Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Apply new design to Crowdsales List / Manage Section #1237

Merged
merged 65 commits into from
Nov 29, 2018
Merged

(Feature) Apply new design to Crowdsales List / Manage Section #1237

merged 65 commits into from
Nov 29, 2018

Conversation

gabitoesmiapodo
Copy link

Closes #1145
Closes #1091

Description

New styles for Crowdsales' List and Manage Crowdsale sections.

Some Screenshots

Crowdsales List:

localhost_3000_manage_0x787c67b858fc7f7395cbd0837b4536d010e85499 laptop with mdpi screen
localhost_3000_crowdsales ipad
localhost_3000_crowdsales nexus 6p

Manage Crowsale:

  • The "Crowdsale Page" link is not in the same place than in the design because it is not possible to do that currently using that "Title / Description" component, and because I think the link would get lost there from an usability point of view.
  • There's no responsive / mobile design for this section, so I took some decisions along the way.

Dutch Auction:

localhost_3000_manage_0x787c67b858fc7f7395cbd0837b4536d010e85499 ipad
localhost_3000_manage_0x787c67b858fc7f7395cbd0837b4536d010e85499 laptop with mdpi screen 1
localhost_3000_manage_0x787c67b858fc7f7395cbd0837b4536d010e85499 nexus 6p

Whitelist With Cap:

localhost_3000_manage_0x787c67b858fc7f7395cbd0837b4536d010e85499 laptop with mdpi screen 2
localhost_3000_manage_0xbf0cee5e86a1d95eca9d0bf97cd3786abd21c989 ipad
localhost_3000_manage_0xbf0cee5e86a1d95eca9d0bf97cd3786abd21c989 nexus 6p

gabitoesmiapodo and others added 30 commits November 7, 2018 17:10
@gabitoesmiapodo
(fix) changed "Contribute" folder name.
a745de5
@gabitoesmiapodo
Merge branch 'integration/#1082-new-design' into feature/#1090-apply-…
507a81c 
…new-design-to-step-6-contribute

* integration/#1082-new-design:
  (fix) test for NoWeb3 component.
  (Add) tests for ButtonNiftyWallet and ButtonMetamask.
  Added URLs to noweb3 component's links.
  (feature) added metamask and nifty wallet buttons
  (feature) added noweb3 component
@gabitoesmiapodo
(feature) contribute page - refactored steps navigation, added contri…
8f9c511 
…bute page
@gabitoesmiapodo
Merge branch 'integration/#1082-new-design' into feature/#1090-apply-…
cb9caff 
…new-design-to-step-6-contribute

* integration/#1082-new-design:
  Tests.
  (chore) changed home components's names to something more meaningful - updated tests - refactored scss - added warning text about pending crowdsale creation.
  Update snapshots
  Fix logo redirect
  Fix check metamask when resume crowdsale
  Add resume or cancel crowdsale

# Conflicts:
#	src/assets/stylesheets/styles.css
@gabitoesmiapodo
styles
f530c57
@gabitoesmiapodo
(feature) Contribute page advances.
06cabf6
@gabitoesmiapodo
Merge branch 'integration/#1082-new-design' into feature/#1090-apply-…
e67f20d 
…new-design-to-step-6-contribute

* integration/#1082-new-design:
  Add gas price custom default value
@gabitoesmiapodo
Merge branch 'integration/#1082-new-design' into feature/#1090-apply-…
d1b926b 
…new-design-to-step-6-contribute

* integration/#1082-new-design:
  Remove loader in provider
  Update snapshots
  Solve glitch between the steps
  Remove loader on these steps

# Conflicts:
#	src/components/StepThree/index.js
@gabitoesmiapodo
(Add) Contribute page styling.
7091940
@gabitoesmiapodo
(feature) contribute page - (add) new circle component - (add) compon…
ba58b24 
…ents and elements styles
@gabitoesmiapodo
Added a blinker to the crowdsale timer.
d7f7050
@gabitoesmiapodo
(fix) removed hours conditional
0e20498
@gabitoesmiapodo
Merge branch 'integration/#1082-new-design' into feature/#1090-apply-…
4acb400 
…new-design-to-step-6-contribute

* integration/#1082-new-design:
  Add before unload warning

# Conflicts:
#	src/components/StepFour/index.js
@gabitoesmiapodo
(fix) current step wasn't shown correctly
82dd6f3
@gabitoesmiapodo
Changed Contribute's test folder's name case.
39f3aba
@gabitoesmiapodo
(chore) tests for contribute sections
06ed76e
@gabitoesmiapodo
(add) contribute tests
a58cfc8
@gabitoesmiapodo
(Add) ModalContainer test.
1cda629
@gabitoesmiapodo
(chore) tests for InputField2 and ButtonCopyToClipboard
275d21a
Update countdown timer
645b36a
Fix some references and update snapshots
bb915c4
@gabitoesmiapodo
(chore) add whitelisttable test
31691c1
Change alert on contribution
697449f
Merge branch 'feature/#1090-apply-new-design-to-step-6-contribute' of…
162231e 
… github.com:poanetwork/token-wizard into feature/#1090-apply-new-design-to-step-6-contribute
@gabitoesmiapodo
(chore) removed old sass / css, left restyling version only.
6c70604
@gabitoesmiapodo
(chore) changed remaining component's folder's names to being capital…
1aaa39c 
…ized.
@gabitoesmiapodo
(add) new regular standard containers / titles / menu to all remainin…
37da6df 
…g sections.
@gabitoesmiapodo
(add) crowdsale's list styling
02d83ab
@gabitoesmiapodo
(add) back button to manage section
dd1845b
@gabitoesmiapodo
(add) Finalize Crowdsale styling.
32911ef
Mariano Aguero and others added 4 commits November 28, 2018 14:33
Update crowdsale is ended or finalized or soldout, apply pad function
9fc15ce
@gabitoesmiapodo
Updates on manage section.
ec7b75c
@gabitoesmiapodo
Merge branch 'feature/#1090-apply-new-design-to-step-6-contribute' in…
9837345 
…to feature/#1145-apply-new-design-to-crowdsales-list

* feature/#1090-apply-new-design-to-step-6-contribute:
  Update crowdsale is ended or finalized or soldout, apply pad function
  Add pad function
@gabitoesmiapodo
(feature) final manage crowdsale section elements
40f3181
@ghost ghost assigned gabitoesmiapodo Nov 28, 2018
@ghost ghost added the in progress label Nov 28, 2018
@dennis00010011b
Copy link

dennis00010011b commented Nov 28, 2018 •
edited
Loading

@gabitoesmiapodo @mariano-aguero
Since the manage page is accessible for users around the world then it needs to specify the time zone for start/end times. Time format could be like on Publish page, converted to UTC+0000

screen shot 2018-11-28 at 12 37 51

@dennis00010011b
Copy link

dennis00010011b commented Nov 28, 2018 •
edited
Loading

@gabitoesmiapodo @mariano-aguero
Need remove reserved tokens block for non-owners accounts
screen shot 2018-11-28 at 12 45 46
Related #811

This was referenced Nov 29, 2018
Open
Open
@gabitoesmiapodo
Copy link
Author

@dennis00010011b

Since development of TW is halting for now (see https://medium.com/poa-network/farewell-token-wizard-2-0-time-to-reprioritize-8cbd7319a97b), I think we need to keep this issue / PR exclusively for the rebranding / visual style related work.

Please create separate issues for any new business logic related problems you may find, as these problems still exist and we or anyone else might fix them in the future.

I've created issues for #1237 (comment) and #1237 (comment) : #1239 / #1238

If there aren't any more visual / UI problems and we have your approval for this PR we will proceed to merge it and finish this part of the job.

@gabitoesmiapodo
Merge branch 'feature/#1090-apply-new-design-to-step-6-contribute' in…
2c82abf 
…to feature/#1145-apply-new-design-to-crowdsales-list

* feature/#1090-apply-new-design-to-step-6-contribute:
  Change message to Crowdsale has ended if tier is sold out
  Update isStarted state on ticks
  Show message You are not allowed if crowdsale is not started
@mariano-aguero mariano-aguero mentioned this pull request Nov 29, 2018
Open
@mariano-aguero
Copy link
Contributor

LGTM, added some improvements in another issue
#1240

@mariano-aguero
Copy link
Contributor

I will merge this branch when the issue #1230 be approved

Mariano Aguero added 2 commits November 29, 2018 14:59
Remove loader
1f8e6de
Merge branch 'feature/#1145-apply-new-design-to-crowdsales-list' of g…
363cd42 
…ithub.com:poanetwork/token-wizard into feature/#1145-apply-new-design-to-crowdsales-list
@ghost ghost assigned mariano-aguero Nov 29, 2018
@mariano-aguero mariano-aguero merged commit 8c11e37 into integration/#1082-new-design Nov 29, 2018
@ghost ghost removed the awaiting for review label Nov 29, 2018
@mariano-aguero mariano-aguero deleted the feature/#1145-apply-new-design-to-crowdsales-list branch November 29, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariano-aguero mariano-aguero mariano-aguero approved these changes

@dennis00010011b dennis00010011b dennis00010011b approved these changes

Assignees

@mariano-aguero mariano-aguero

@gabitoesmiapodo gabitoesmiapodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabitoesmiapodo @dennis00010011b @mariano-aguero