(Fix) manage crowdsale to allow edit if it didn't started yet #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Black Duck Security ReportMerging #521 into master will not change security risk. Added ComponentsClean: 182 Removed ComponentsClean: 236 |
fvictorio
suggested changes
Jan 26, 2018
src/components/manage/utils.js
Outdated
| if (contract.startDate <= currentDate && currentDate <= contract.endDate) contract.current = true | ||
| const { startDate, endDate } = contract | ||
|
|
||
| if (index === 0 && currentDate < startDate || startDate <= currentDate && currentDate <= endDate) { |
There was a problem hiding this comment.
This condition is a little hard to read. At the very least we should use parentheses to make the precedence clear:
if ((index === 0 && currentDate < startDate) || (startDate <= currentDate && currentDate <= endDate))
Even better, extract the sub-conditions to variables:
const isActive = startDate <= currentDate && currentDate <= endDate
const isFirstTier = index === 0
if (isActive || (isFirstTier && currentDate < startDate)
There was a problem hiding this comment.
updated, thanks!
fvictorio
approved these changes
Jan 26, 2018
vbaranov
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #519