(Fix) Add validation to decimals - support copy&paste #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…568' into add-validation-to-decimals-fix-#568 # Conflicts: # src/components/Common/NumericInput.js
ghost
assigned 
fvictorio
approved these changes
Feb 20, 2018
|
@fernandomg could you get upstream from master branch to fix CI? |
Pull Request Test Coverage Report for Build 1483
💛 - Coveralls |
|
@vbaranov done |
vbaranov
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #568
Due to: #568 (comment)
NumericInputsupportsmin,max,floats,minDecimals,maxDecimalsattributes.The events that are being handled:
onPaste, if the text being pasted is not a number, it won't be pasted.onKeyPress, prevents the user from entering floating number related symbols if it's not allowedonChange, evaluate all the component's conditions