-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feature) e2e tests for Wizard #660
Conversation
.travis.yml
Outdated
- export DISPLAY=:99.0 | ||
- sh -e /etc/init.d/xvfb start | ||
- npm i -g npm@^3 | ||
- sleep 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dennis00010011b could you clarify why it is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vbaranov @fvictorio
Xvfb is needed for performs graphical operations in virtual memory. e2e script uses Metamask extension but headless Chrome don't support extension. It is why Xvfb used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asking about the sleep 3
line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended code from https://docs.travis-ci.com/user/gui-and-headless-browsers/
sleep 3
give xvfb some time to start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dennis00010011b did you try other setups from recommended in the link above? if yes, do they work? just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too much. I just tried to play with screen resolution but it wasn't helpfull
@fvictorio @fernandomg let's do not merge any PR until we will not add e2e tests. |
Pull Request Test Coverage Report for Build 1588
💛 - Coveralls |
@fernandomg @fvictorio is there anything stops us from merging? |
@vbaranov I'm running it locally, but I'm getting the following
|
@fernandomg please try to restart tests. You can see it worked with this PR. Anyway, @dennis00010011b will try to increase stability in the next releases of test-automation script. |
@fernandomg There is should be result.log file(see path ./results/result_date_time/) Could you send it me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it worked. Thanks!
Sorry, I moved to another issue and cleaned up the workspace. Now it worked. Thanks |
@vbaranov I think this can be merged now. |
Closes #509
Problem: we have no integrated e2e tests for Token Wizard
Solution: integrate
token-wizard-test-automation
as a submodule