Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) walletAddress validation in stepThree #702

Merged
merged 10 commits into from
Mar 23, 2018
Merged

(Fix) walletAddress validation in stepThree #702

merged 10 commits into from
Mar 23, 2018

Conversation

fernandomg
Copy link
Contributor

Closes #675

  • Removed address validation in utility library
  • Added validation with web3 for the address

@ghost ghost assigned fernandomg Mar 15, 2018
@ghost ghost added the in progress label Mar 15, 2018
@coveralls
Copy link

coveralls commented Mar 15, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1790

  • 9 of 15 (60.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 16.7%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stores/TierStore.js 0 2 0.0%
src/components/stepThree/index.js 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/utils/utils.js 1 33.87%
src/components/stepThree/index.js 1 0.0%
Totals Coverage Status
Change from base Build 1786: 0.3%
Covered Lines: 409
Relevant Lines: 1951
💛 - Coveralls

vbaranov
vbaranov reviewed Mar 15, 2018
View reviewed changes
Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with changes, but there are no tests for wallet address changing.

vbaranov
vbaranov reviewed Mar 22, 2018
View reviewed changes
Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fernandomg I can't jump to step 4. Do you have the same issue?

https://goo.gl/mYbFrG

@fernandomg
Copy link
Contributor Author

@fernandomg I can't jump to step 4. Do you have the same issue?

Yes, same issue here, fixed merge error.

@vbaranov vbaranov merged commit 479d2cd into master Mar 23, 2018
@ghost ghost removed the awaiting for review label Mar 23, 2018
@vbaranov vbaranov deleted the validate-wallet-address-#675 branch March 23, 2018 16:53
This was referenced Apr 3, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvictorio fvictorio fvictorio approved these changes

@vbaranov vbaranov vbaranov approved these changes

Assignees

@fernandomg fernandomg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fernandomg @coveralls @fvictorio @vbaranov