(Fix) Update fields in reverse order and endTimes before startTimes #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build 1851
💛 - Coveralls |
fernandomg
approved these changes
Apr 4, 2018
vbaranov
approved these changes
Apr 6, 2018
This was referenced Apr 6, 2018
This was referenced Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728.
When updating fields, perform the transactions for the tiers in reverse order (the last tier first, then the second-to-last, etc.). Within tiers, update the end date before the start date. This way both the start and end date can be updated at the same time even if the new start date is after the old end date.